Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move proto codec to separate Go module #138

Merged
merged 3 commits into from
Nov 4, 2023

Conversation

philippgille
Copy link
Owner

@philippgille philippgille commented Oct 31, 2023

Reasoning: To not force the proto transitive dependency on users who import the encoding package while only using stdlib codecs, as mentioned here.

@philippgille
Copy link
Owner Author

Cc @glimchb , is this okay for you?

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #138 (2a8d6e7) into master (e95ea56) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   65.26%   65.26%           
=======================================
  Files          25       25           
  Lines        2096     2096           
=======================================
  Hits         1368     1368           
  Misses        601      601           
  Partials      127      127           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@glimchb
Copy link
Contributor

glimchb commented Oct 31, 2023

Cc @glimchb , is this okay for you?

sure. maybe just add quick example of new usage...

@philippgille
Copy link
Owner Author

sure. maybe just add quick example of new usage...

Good idea 👍 . I just created one and it works fine, but I'll submit that in a separate PR.

To not force the proto transitive dependency on users who import the encoding package while only
using stdlib codecs.
Like encoding.JSON and encoding.Gob, but here just Codec because we're in the proto package
and want to avoid stuttering.
@philippgille philippgille force-pushed the move-proto-codec-to-separate-go-module branch from 966fc3a to 2a8d6e7 Compare November 4, 2023 21:43
@philippgille philippgille merged commit 087cefb into master Nov 4, 2023
4 checks passed
@philippgille
Copy link
Owner Author

PR for the code example: #144

@philippgille philippgille deleted the move-proto-codec-to-separate-go-module branch January 7, 2024 15:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants