Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Skip etcd concurrency test in CI #172

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

philippgille
Copy link
Owner

@philippgille philippgille commented Jan 21, 2024

As the code comment says, there are issues with the concurrency test for etcd in CI, but they are not reproducible locally, and also don't always happen in CI.

Previous fix attempts haven't worked:

We skip the test in CI as a temporary workaround, and before a release we can and should run all tests locally to include this one.

I also searched a bit on the web, the etcd GitHub Discussions and their Google Group.

In the future we could post a question in one of their communities.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e697dc) 56.69% compared to head (4fb7703) 63.64%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   56.69%   63.64%   +6.95%     
==========================================
  Files          11       25      +14     
  Lines         822     2107    +1285     
==========================================
+ Hits          466     1341     +875     
- Misses        327      651     +324     
- Partials       29      115      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippgille philippgille marked this pull request as ready for review January 21, 2024 18:14
@philippgille philippgille merged commit 918b014 into master Jan 21, 2024
8 checks passed
@philippgille philippgille deleted the skip-etcd-concurrency-test-in-ci branch January 21, 2024 18:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants