Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adjust span start based on previous replacements #145

Closed
jzonthemtn opened this issue Sep 24, 2024 · 1 comment
Closed

Adjust span start based on previous replacements #145

jzonthemtn opened this issue Sep 24, 2024 · 1 comment
Assignees
@jzonthemtn
Milestone
2.8.0

Comments

@jzonthemtn
Copy link
Member

jzonthemtn commented Sep 24, 2024 •
edited
Loading

The fix for #126 introduced a problem where the spans that needed to be replaced would not have their start/end updated accordingly after doing a prior replacement.

The issue is the code is updating identifiedSpans and not appliedSpans.

Example - the following text:

George Washington was president and his ssn was {{{REDACTED-ssn}}} and he lived at {{{REDACTED-zip-code}}}.

would be redacted as:

George Washington was president and his ssn was {{{REDACTED-ssn}}} and he li{{{REDACTED-zip-code}}}t 90210.

This needs a unit test.
@jzonthemtn jzonthemtn added this to the 2.8.0 milestone Sep 24, 2024
@jzonthemtn jzonthemtn self-assigned this Sep 24, 2024
jzonthemtn added a commit that referenced this issue Sep 24, 2024
@jzonthemtn
#145 Fixing span start/end with applied spans.
de405fd
jzonthemtn added a commit that referenced this issue Sep 25, 2024
@jzonthemtn
#145 Fixing span start/end with applied spans.
73fee0b
@jzonthemtn
Copy link
Member Author

jzonthemtn commented Sep 25, 2024 •
edited
Loading

Backported to 2.7.1.

JessieAMorris pushed a commit to JessieAMorris/phileas that referenced this issue Dec 16, 2024
@jzonthemtn
philterd#145 Fixing span start/end with applied spans.
996d2e9
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jzonthemtn jzonthemtn

Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

No branches or pull requests
1 participant
@jzonthemtn