Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove the default value before the required parameter. #1618

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Remove the default value before the required parameter. #1618

merged 1 commit into from
Jul 28, 2021

Conversation

tasuku43
Copy link

Fixed the case where a parameter with a default value followed by a required parameter was deprecated in PHP 8.0.0 and later.

Reference: https://www.php.net/manual/en/migration80.deprecated.php

@tasuku43 tasuku43 changed the title Remove the initial value before the required parameter. Remove the default value before the required parameter. Jul 27, 2021
@siad007 siad007 merged commit c113f8f into phingofficial:oldstable Jul 28, 2021
@siad007
Copy link
Member

siad007 commented Jul 28, 2021

@Task2021 thank you!

@siad007
Copy link
Member

siad007 commented Jul 28, 2021

@Task2021 you have made your changes to an old branch! Please do changes against main branch.

@mrook
Copy link
Member

mrook commented Jul 28, 2021

@Task2021 FYI, we intend 2.16.4 to be the last release of the 2.x series, while we are working on releasing Phing 3.0. Thanks!

@tasuku43
Copy link
Author

@mrook

we intend 2.16.4 to be the last release of the 2.x series

Tank you!
I'm sorry, my intention was to submit a fix for the stable branch.

@siad007

you have made your changes to an old branch! Please do changes against main branch.

Okay, thank you very much!

mrook added a commit that referenced this pull request Aug 27, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

3 participants