Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

performance refactoring for calendar views #186

Merged
merged 12 commits into from
Dec 7, 2021
Merged

performance refactoring for calendar views #186

merged 12 commits into from
Dec 7, 2021

Conversation

rkrenn
Copy link
Collaborator

@rkrenn rkrenn commented Nov 12, 2021

calendar events have an icon to indicate conflicts (ie. staff assigned while on vacation). a new filter tickbox is added which allows to disable calculating the conflicts for a better load times.

furthermore, recent profiling turned out that redundant (re-)loading details of displayed events are another reason for slow loading times, especially with lots of events visible. this caused a high frequency of unneccesary service method invocations, which can be avoided.

with this fix, load times of month views with hundreds of items is as low as 2 secs.

grafik

this change also introduces knobs exposed via settings.properties file, which allow to show/hide the increasing number of filter and display options of calendar and timeline views.

@rkrenn rkrenn requested a review from ultchagen November 17, 2021 12:01
@rkrenn rkrenn requested a review from SigridDeller November 18, 2021 10:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

0.0% 0.0% Coverage
7.3% 7.3% Duplication

@rkrenn rkrenn linked an issue Nov 24, 2021 that may be closed by this pull request
@rkrenn rkrenn merged commit 49d1efc into master Dec 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve performance of calendar views
1 participant