-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
timezone conversion support for Rest-API #189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolService.isEcrfFieldUserTimeZone(Long ecrfFieldId) toolService.isInquiryUserTimeZone(Long inquiryId) toolService.isProbandListEntryTagUserTimeZone(Long probandListEntryTagId)
Kudos, SonarCloud Quality Gate passed! |
This was referenced Dec 31, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so far, the implementation uses the UserTimezone setting in the JSF UI layer only:
so the proper solution here is to complete the implementation:
this change addresses point 3 above, the timezone conversion when using the Rest-API, eg. for eCRF data exports.
the timezone conversion can be enabled by providing the optional "?tz=" query parameter in the request URLs, eg. "?tz=America/Chicago":
For eCRF/Inquiry/SubjectListAttribute input, the the timezone conversion can be controlled by the inputfield's "User Timezone" flag (the above conversion is done only if ticked).
finally also UIdatatable&rest-api items filtering is improved: