enter individual visit offsets&durations #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrenn
requested review from
fladi,
VeitWeber,
Kalandus,
Jensrib,
codonAG2,
SigridDeller,
ultchagen and
01hasenberger
false positive from sonarcloud, since the intermediate int math result here will not exceed the value range of int values.
|
Kudos, SonarCloud Quality Gate passed! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this enhancement replaces the "duration" and "offset" dropdowns in the visit schedule tab with p:autocomplete input fields.
a new parser will accept entered duration labels such as "1day, 2.5hours, 3 mins". it converts it into a value seconds for persisting it in the database (eg. 1 * 24 * 60 * 60 + 2.5 * 60 * 60 + 3 * 60 = 95580 seconds). in turn, that value will be printed in canonical form eg. "1 day, 2 hours, 33 mins".