use makeup_syntect for highlighting JS (and diff) #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Feb 7, 2025
| @@ -34,7 +34,7 @@ defmodule PhoenixHTML.Mixfile do | |||
| [ | |||
| {:ex_doc, ">= 0.0.0", only: :docs}, | |||
| {:makeup_eex, ">= 0.1.1", only: :docs}, | |||
| {:makeup_diff, "~> 0.1", only: :docs} | |||
| {:makeup_syntect, "~> 0.1.0", only: :docs} | |||
There was a problem hiding this comment.
I am not sure if the extra dependencies are worth it for one single snippet of JavaScript code, but it is your call :)
There was a problem hiding this comment.
As it's only a dependency for the docs, I really don't care. If that ever breaks, it's easy to rip out.
josevalim
approved these changes
Feb 7, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: