Enable external uploader progress data #3663
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be nice if the client could push additional progress-related data to the server during external uploads. Adding a
progress_data
field to thePhoenix.LiveView.UploadEntry
struct would enable LiveView to support client-side S3-compatible multipart uploads without extra server requests. This would allow the client to collect part_number and etag for each uploaded part and make them available whenconsume_uploaded_entries/3
is invoked to complete the multipart upload. Currently, the only way to send etags or any additional uploader data to the server is by hijacking hook events or making separate requests.Below is an example of what this PR code can enable:
Form:
Uploader: