Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Cannot install phonegap-plugin-push on master #1470

Closed
CookieCookson opened this issue Dec 16, 2016 · 6 comments
Closed

Cannot install phonegap-plugin-push on master #1470

CookieCookson opened this issue Dec 16, 2016 · 6 comments
Labels
android bug docs
Milestone
Release 2.0.0

Comments

@CookieCookson
Copy link
Contributor

Expected Behaviour

Plugin to be installed successfully

Actual Behaviour

Cordova CLI throws an undefined error

Reproduce Scenario (including but not limited to)

N/A

Steps to Reproduce

cordova plugin add https://github.com/phonegap/phonegap-plugin-push#1b17756ea5e7f3e33de7f1852737e66e909dc9c0

Platform and Version (eg. Android 5.0 or iOS 9.2.1)

All

(Android) What device vendor (e.g. Samsung, HTC, Sony...)

N/A

Cordova CLI version and cordova platform version

cordova 6.4.0
cordova-android 6.1.0

Plugin version

From master
(1b17756)

Sample Push Data Payload

N/A

Sample Code that illustrates the problem

N/A

Logs taken while reproducing problem

screen shot 2016-12-16 at 09 56 20
@jcesarmobile
Copy link
Collaborator

do you have the google-services.json in www folder?

@CookieCookson
Copy link
Contributor Author

CookieCookson commented Dec 16, 2016 •
edited
Loading

I do, and it's exported from the Firebase dashboard.

I have a feeling it is to do with the upgrades to the Android dependencies made in the latest commit referenced above.

@jcesarmobile
Copy link
Collaborator

I think the error message is wrong and you should put it in the root of the project, not in www (looking into the hook code)

@CookieCookson
Copy link
Contributor Author

You're right! Moving it to the root worked perfectly. Would it be the www folder for pg-build projects?

@jcesarmobile
Copy link
Collaborator

No, I think it was just a mistake, and hooks doesn't work on PGB

@macdonst macdonst added this to the Release 2.0.0 milestone Dec 16, 2016
macdonst added a commit that referenced this issue Dec 21, 2016
@macdonst
🐧📝🐛 Issue #1470: Cannot install phonegap-plugin-push on master
3f784bc
macdonst added a commit that referenced this issue Jan 4, 2017
@macdonst
🐧📝🐛 Issue #1470: Cannot install phonegap-plugin-push on master
e2f8a62
macdonst added a commit that referenced this issue Jan 6, 2017
@macdonst
🐧📝🐛 Issue #1470: Cannot install phonegap-plugin-push on master
e2fe38a
macdonst added a commit that referenced this issue Jan 12, 2017
@macdonst
🐧📝🐛 Issue #1470: Cannot install phonegap-plugin-push on master
41c8e66
macdonst added a commit that referenced this issue Apr 29, 2017
@macdonst
🐧📝🐛 Issue #1470: Cannot install phonegap-plugin-push on master
a1fa7cc
macdonst added a commit that referenced this issue May 5, 2017
@macdonst
🐧📝🐛 Issue #1470: Cannot install phonegap-plugin-push on master
632a4f1
macdonst added a commit that referenced this issue May 24, 2017
@macdonst
🐧📝🐛 Issue #1470: Cannot install phonegap-plugin-push on master
107e600
macdonst added a commit that referenced this issue May 25, 2017
@macdonst
Merge v2.0.x into master (#1736)
d07fdf0 
* Added partial Android FCM support (#975)

* Modified plugin.xml to include FCM changes

* Plugin.xml changes for FCM

* Java changes for FCM

* Increased plugin version to 2.0.0

* Increased plugin version in package.json

* Added topic subscription/unsubscription

* Removed some empty lines

* Fixed empty token on android first run (#1008)

* Removed GCM files and added FCM files

* Added .framework files as custom frameworks

* Changed code to work with FCM

* Added hook and resource file to copy GoogleService-Info.plist

* fixed registration and removed unused code

* Use CocoaPods

* Fix rebase errors

* Fix topic subscription and unsubscription on FCM

* Refactor GCMIntentService to FCMService

* Issue #689: Remove sender id from PushNotification init Android options

* Issue #689: Remove sender id from PushNotification init iOS options

* 📝 Update to using fcm-node

* 🐛 Issue #1188: Strings.xml google_app_id conflict with google-services.json

* Add empty google services plist

* Pin FCM to 9.8.0

* 🔧 Add browser platform back for FCM branch

* 🔨🔧⬆️ Use Babel to transpile ES2015 code

* 🔧 add tern to gitignore

* 🔖 Bumping plugin version to 2.0.0-rc1

* 2.0.0-rc1

* Updating CHANGELOG

* Fixing my merge error for PR #1378 Optional event emit instead of function call for action buttons

* 🐛🍎 Issue #1461: App crashes when initialising with topics (v2.0.0-rc1)

* 🐛🐧📝⬆️ #1460: Build Issue Android

* 🐛🍎🔧 Fixing a merge issue where aps-environment was accidentally removed

* 🐧📝🐛 Issue #1470: Cannot install phonegap-plugin-push on master

* 📝 Using a newer version on the examples

* 🍎🐛 Issue #1497: App crashes after refreshing when using FCM (v2)

* Bumping plugin version to 2.0.0-rc2

* 2.0.0-rc2

* Updating CHANGELOG

* Added partial Android FCM support (#975)

* Modified plugin.xml to include FCM changes

* Plugin.xml changes for FCM

* Java changes for FCM

* Increased plugin version to 2.0.0

* Increased plugin version in package.json

* Added topic subscription/unsubscription

* Removed some empty lines

* Removed GCM files and added FCM files

* Changed code to work with FCM

* Added hook and resource file to copy GoogleService-Info.plist

* Use CocoaPods

* Fix rebase errors

* Issue #689: Remove sender id from PushNotification init Android options

* 🐛 Issue #1188: Strings.xml google_app_id conflict with google-services.json

* Pin FCM to 9.8.0

* 🔧 Add browser platform back for FCM branch

* 🔨🔧⬆️ Use Babel to transpile ES2015 code

* 🔧 add tern to gitignore

* 🔖 Bumping plugin version to 2.0.0-rc1

* 🐛🐧📝⬆️ #1460: Build Issue Android

* Bumping plugin version to 2.0.0-rc2

* Added partial Android FCM support (#975)

* Modified plugin.xml to include FCM changes

* Plugin.xml changes for FCM

* Java changes for FCM

* Increased plugin version to 2.0.0

* Increased plugin version in package.json

* Added topic subscription/unsubscription

* Removed some empty lines

* Removed GCM files and added FCM files

* Added hook and resource file to copy GoogleService-Info.plist

* Use CocoaPods

* Fix rebase errors

* 🐛 Issue #1188: Strings.xml google_app_id conflict with google-services.json

* Updating CHANGELOG

* ✏️ fixing error in CHANGELOG

* Bumping plugin version to 2.0.0-rc2

* Updating CHANGELOG

* Added partial Android FCM support (#975)

* Modified plugin.xml to include FCM changes

* Plugin.xml changes for FCM

* Java changes for FCM

* Increased plugin version to 2.0.0

* Increased plugin version in package.json

* Added topic subscription/unsubscription

* Removed some empty lines

* Removed GCM files and added FCM files

* Changed code to work with FCM

* Added hook and resource file to copy GoogleService-Info.plist

* fixed registration and removed unused code

* Use CocoaPods

* Fix rebase errors

* Issue #689: Remove sender id from PushNotification init Android options

* Issue #689: Remove sender id from PushNotification init iOS options

* 🐛 Issue #1188: Strings.xml google_app_id conflict with google-services.json

* 🔧 add tern to gitignore

* 🔖 Bumping plugin version to 2.0.0-rc1

* Bumping plugin version to 2.0.0-rc2

* Remove hook and use resource-file tag to copy google services file

* Add resource-file way of copying google services files

* Bump requirements

* 🔧 Update cordovaDependencies

* 🔖 Bumping plugin version to 2.0.0-rc3

* 2.0.0-rc3

* Updating CHANGELOG

* Fixes 'framework not found GoogleToolboxForMac' linker error in 2.0.0-rc3 (#1715)

* Remove unused files (#1732)

* Remove GTM framework. (#1739)
@lock
Copy link

lock bot commented Jun 4, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
android bug docs
Milestone
Release 2.0.0
Development

No branches or pull requests
3 participants
@macdonst @jcesarmobile @CookieCookson