Skip to content

feat: add currency property and option #12

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Aug 31, 2023
Merged

feat: add currency property and option #12

merged 4 commits into from
Aug 31, 2023

Conversation

ramsey
Copy link
Member

@ramsey ramsey commented Aug 31, 2023

Description

Adds the ability to set the currency type for the locale.

Motivation and context

This feature is not defined in ECMA-402, but it is inspired by the Intl Info Proposal and is implemented to behave like the other properties.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #12 (46f9e40) into main (23fd04e) will increase coverage by 0.24%.
The diff coverage is 89.13%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   82.27%   82.52%   +0.24%     
==========================================
  Files          12       12              
  Lines         942      984      +42     
  Branches      182      190       +8     
==========================================
+ Hits          775      812      +37     
- Misses         94       97       +3     
- Partials       73       75       +2     
Flag Coverage Δ
unittests 82.52% <89.13%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/ecma402/locale.cpp 77.14% <87.80%> (+0.90%) ⬆️
src/ecma402/language_tag.cpp 80.68% <100.00%> (+0.42%) ⬆️

@ramsey ramsey merged commit 5a6f6e5 into main Aug 31, 2023
@ramsey ramsey deleted the locale-currency branch August 31, 2023 16:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant