Skip to content

split MINIT for each classes #6

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 11 commits into from
Aug 30, 2023
Merged

Conversation

remicollet
Copy link
Contributor

Currently, arginfo.h is included everywhere so lot of "static" data/code are duplicated

This also raise build warnings

In file included from /work/GIT/pecl-and-ext/ecma_intl/src/php/php_common.h:25,
                 from /work/GIT/pecl-and-ext/ecma_intl/src/php/ecma_intl.h:16,
                 from /work/GIT/pecl-and-ext/ecma_intl/src/php/ecma_intl.c:17:
/work/GIT/pecl-and-ext/ecma_intl/src/php/ecma_intl_arginfo.h:460:26: warning: 'register_class_Ecma_Intl_Locale_WeekDay' defined but not used [-Wunused-function]
  460 | static zend_class_entry *register_class_Ecma_Intl_Locale_WeekDay(void)
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/work/GIT/pecl-and-ext/ecma_intl/src/php/ecma_intl_arginfo.h:441:26: warning: 'register_class_Ecma_Intl_Locale_TextInfo' defined but not used [-Wunused-function]
  441 | static zend_class_entry *register_class_Ecma_Intl_Locale_TextInfo(zend_class_entry *class_entry_JsonSerializable)
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/work/GIT/pecl-and-ext/ecma_intl/src/php/ecma_intl_arginfo.h:375:26: warning: 'register_class_Ecma_Intl_Locale_Options' defined but not used [-Wunused-function]
  375 | static zend_class_entry *register_class_Ecma_Intl_Locale_Options(zend_class_entry *class_entry_Iterator, zend_class_entry *class_entry_JsonSerializable)
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/work/GIT/pecl-and-ext/ecma_intl/src/php/ecma_intl_arginfo.h:358:26: warning: 'register_class_Ecma_Intl_Locale_CharacterDirection' defined but not used [-Wunused-function]
  358 | static zend_class_entry *register_class_Ecma_Intl_Locale_CharacterDirection(void)
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/work/GIT/pecl-and-ext/ecma_intl/src/php/ecma_intl_arginfo.h:236:26: warning: 'register_class_Ecma_Intl_Locale' defined but not used [-Wunused-function]
  236 | static zend_class_entry *register_class_Ecma_Intl_Locale(zend_class_entry *class_entry_JsonSerializable, zend_class_entry *class_entry_Stringable)
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/work/GIT/pecl-and-ext/ecma_intl/src/php/ecma_intl_arginfo.h:199:26: warning: 'register_class_Ecma_Intl_Category' defined but not used [-Wunused-function]
  199 | static zend_class_entry *register_class_Ecma_Intl_Category(void)
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/work/GIT/pecl-and-ext/ecma_intl/src/php/ecma_intl_arginfo.h:174:26: warning: 'register_class_Ecma_Intl' defined but not used [-Wunused-function]
  174 | static zend_class_entry *register_class_Ecma_Intl(void)
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~
/bin/sh /work/GIT/pecl-and-ext/ecma_intl/libtool --mode=compile g++ -I. -I/work/GIT/pecl-and-ext/ecma_intl -I/work/GIT/pecl-and-ext/ecma_intl/include -I/work/GIT/pecl-and-ext/ecma_intl/main -I/work/GIT/pecl-and-ext

This PR only split stub/arginfo/minit for the WeekInfo class

If you think it make sense, I will do the same for the other classes

@ramsey
Copy link
Member

ramsey commented Aug 29, 2023

@remicollet, this makes sense. Please feel free to do this for the others. Thanks!

@remicollet remicollet changed the title split MINIT for WeekInfo split MINIT for each classes Aug 29, 2023
@remicollet
Copy link
Contributor Author

@ramsey all done ;)
Ready for review

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #6 (c57285c) into main (a0f108f) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files          12       12           
  Lines         942      942           
  Branches      182      182           
=======================================
  Hits          775      775           
  Misses         94       94           
  Partials       73       73           
Flag Coverage Δ
unittests 82.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ramsey
Copy link
Member

ramsey commented Aug 30, 2023

Thank you for contributing! 🎉

@ramsey ramsey merged commit bf1a6e6 into php-ecma-intl:main Aug 30, 2023
@remicollet remicollet deleted the issue-arginfo branch August 30, 2023 05:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants