-
Notifications
You must be signed in to change notification settings - Fork 4
split MINIT for each classes #6
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b839fd3
to
22c5bcd
Compare
@remicollet, this makes sense. Please feel free to do this for the others. Thanks! |
22c5bcd
to
882f71f
Compare
df950ad
to
7022d22
Compare
@ramsey all done ;) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
=======================================
Coverage 82.27% 82.27%
=======================================
Files 12 12
Lines 942 942
Branches 182 182
=======================================
Hits 775 775
Misses 94 94
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. |
Thank you for contributing! 🎉 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
arginfo.h
is included everywhere so lot of "static" data/code are duplicatedThis also raise build warnings
This PR only split stub/arginfo/minit for the WeekInfo class
If you think it make sense, I will do the same for the other classes