Add functionality to parse source as specified encoding and get result as specified encoding #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feyst
force-pushed
the
master
branch
3 times, most recently
from
33e2417 to
9434e4a
Compare
feyst
commented
Oct 15, 2024
| executionOrder="depends,defects" | ||
| requireCoverageMetadata="false" | ||
| beStrictAboutCoverageMetadata="false" |
There was a problem hiding this comment.
Running the tests gave errors that these attributes were not allowed.
feyst
commented
Oct 15, 2024
| static::assertSame(3598, \strlen($interpreter->getJson())); | ||
| static::assertSame(9383, \strlen($interpreter->getJson(true))); | ||
| static::assertSame(3594, \strlen($interpreter->getJson())); | ||
| static::assertSame(9379, \strlen($interpreter->getJson(true))); |
There was a problem hiding this comment.
Before the changes these tests were failing so I adjusted it first
feyst
commented
Oct 15, 2024
| @@ -227,7 +227,7 @@ | |||
| "messageTrailer": { | |||
| "segmentIdx": 20, | |||
| "segmentCode": "UNT", | |||
| "segmentGroup": "SG16", | |||
| "segmentGroup": "", | |||
There was a problem hiding this comment.
Before the changes these tests were failing so I adjusted it first
feyst
force-pushed
the
master
branch
2 times, most recently
from
6ef2f54 to
5d630b4
Compare
|
Thank you! |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #140 we would like to add a feature where you can set the source encoding and also specify the result encoding.