Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump symfony from 6.0 to 6.4 and add support for 7.0 #1326

Closed
wants to merge 3 commits into from

Conversation

snapshotpl
Copy link
Contributor

No description provided.

Copy link
Contributor

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This require the 5.0 release of DoctrineMongoDBBundle
doctrine/DoctrineMongoDBBundle#784

Something like

"doctrine/mongodb-odm-bundle": "^3.5|^4.3|dev-5.0.x"

could be tried.

Comment on lines -83 to -91
exclude:
- php: '7.4'
symfony_version: '6.2.*'
- php: '7.4'
symfony_version: '6.3.*'
- php: '8.0'
symfony_version: '6.2.*'
- php: '8.0'
symfony_version: '6.3.*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to keep exclude for SF 6.4 and SF 7, because

  • SF 6.4 doesn't work on php 7.4 and 8.0
  • SF 7 doesn't work on php 7.4, 8.0 and 8.1

@TechComBiz
Copy link

@snapshotpl are you make the changes to this branch with the feedback? Or what is your planning?

@TechComBiz
Copy link

@VincentLanglet I waiting for this future. So, I have fix your comments in a PR to the code of snapshotpl.
Only, I am new here so I don't know if I do it right: snapshotpl#1

And If snapshot react not quick. Is it then better to make a new PR?

@VincentLanglet
Copy link
Contributor

And If snapshot react not quick. Is it then better to make a new PR?

It seems better indeed because there is still a lot of work.
Look at #1330, lot of build are failing...

If you open a PR, unfortunately I think the CI will need approval to run. (I don't have this issue cause I already contributed).
If you want to can work on the error and I can cherry-pick your commit if you need the CI to run.

@TechComBiz
Copy link

And If snapshot react not quick. Is it then better to make a new PR?

It seems better indeed because there is still a lot of work. Look at #1330, lot of build are failing...

If you open a PR, unfortunately I think the CI will need approval to run. (I don't have this issue cause I already contributed). If you want to can work on the error and I can cherry-pick your commit if you need the CI to run.

I have make an own #1331
Please, give feedback :)

@AlexOstrovsky
Copy link

any update on this?

@makasim
Copy link
Member

makasim commented Nov 18, 2024

#1362

@makasim makasim closed this Nov 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants