feat(GPS): allow send attributes in Google PubSub message.

[p-pichet]

Allow to send PubSub attributes

[p-pichet]

@makasim Can someone look at this PR please ?

[p-pichet]

Hello @dgafka.
Can you review this PR or tell me who can ?

[dgafka]

Hello @p-pichet
I am not maintainer of this package, @makasim is ;)

[p-pichet]

as i saw you approve some requests and i don't have any responses, i ask you but i understand.

[p-pichet]

@makasim

[makasim]

ci pipeline does not trigger for this PR. I dont know why. I cannot merge PR without it being tested on CI succesfully.

[p-pichet]

ci pipeline does not trigger for this PR. I dont know why. I cannot merge PR without it being tested on CI succesfully.

i see why the CI is not trigger.
You are agree with the modification ?

[p-pichet]

I don't understand how to run CI.

[p-pichet]

Hi @makasim, can you run CI actions, please?

[makasim]

I cannot, I would do it if it were possible

[p-pichet]

I hesitate if it was a trigger message.
Do you know the condition to enable the CI ?
Is it because my repository is not correctly setup ?

[makasim]

CI has to be triggered on any MR by default without any additional actions from any side. There is one exception where a maintainer has to approve CI but there is none.

[makasim]

Maybe try open a new PR from new branch, hope it helps

[p-pichet]

@makasim i push a fix, can you run the CI please.

[p-pichet]

@makasim i push a change, can you run the CI please.

[p-pichet]

@makasim i push a change, can you run the CI please.

[p-pichet]

@makasim I push a change, can you run the CI please.
For the version 8.x of PHP, we got issue on the SQS, but I don't touch it. Who can have a look at it ?

[p-pichet]

@makasim We found that the 404 error come from an update of aws/aws-sdk-php.
Who is in charge of the maintenance of external lib ?

[p-pichet]

@makasim I push a change, can you run the CI please.

[p-pichet]

@makasim it's seem the image use to run CI not found the docker compose command.

[p-pichet]

@makasim I push a change, can you run the CI please.

[p-pichet]

@Steveb-p i try something can you run the CI ?

[p-pichet]

@Steveb-p and @makasim, the CI fail on the SQS and SNS.
We don't have strong knowledge to understand what happen.
do you have a name to someone can help use ?
Maybe @ASKozienko as you work on the failing test.

[p-pichet]

@Steveb-p can you run the CI please ?

[p-pichet]

Thanks @Steveb-p
The CI is green.
Who can merge it ?

[Steveb-p]

Thanks @Steveb-p The CI is green. Who can merge it ?

Let me review the code after work, just in case.

[p-pichet]

@Steveb-p can you run the CI and take a new look on the code please ?

[p-pichet]

@Steveb-p, I push the missing code style.
Can you run the CI please ?
And as you validate the PR, what I need to do for its merge ?

[Steveb-p]

LGTM.

I will leave it for a while before merging, probably for a day.

Unless there are any comments from @makasim or anyone else.

[p-pichet]

Forgot the part to get the attributes on receive a message.

[makasim]

uncomment please, I need it while releasing new tag.

[p-pichet]

sorry

[makasim]

set a fixed version please

[makasim]

Few comments from me, Almost there.

[p-pichet]

@Steveb-p and @makasim i push a fix for your comment and a code to get attributes for received.
Can you run the CI and validate the PR please ?

[makasim]

@p-pichet big thank you for your tireless work. Enqueue's CI is green and it not only provides the feature you need but unblocks a lot of other stuck MRs.

Kudos to you, much appreciated!

[p-pichet]

@p-pichet big thank you for your tireless work. Enqueue's CI is green and it not only provides the feature you need but unblocks a lot of other stuck MRs.

Kudos to you, much appreciated!

Thanks a lot.
When do you think the release will be created ?

[makasim]

released https://github.com/php-enqueue/enqueue-dev/blob/master/CHANGELOG.md#01021-2024-08-12