Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PSR-7] Removes trailing spaces from proposal #351

Merged
merged 1 commit into from
Oct 14, 2014
Merged

[PSR-7] Removes trailing spaces from proposal #351

merged 1 commit into from
Oct 14, 2014

Conversation

sagikazarmark
Copy link
Member

No description provided.

@sagikazarmark
Copy link
Member Author

Only one is kept which is considered to be a space between two sentences which are on different line.

@weierophinney
Copy link
Contributor

@philsturgeon This is good to merge.

@sagikazarmark
Copy link
Member Author

Please check that the content referred by my comment is ok. (There is an extra space which is marked as an extra trailing space by sublime)

@weierophinney
Copy link
Contributor

@sagikazarmark Based on the diff, it looks fine.

@sagikazarmark
Copy link
Member Author

There is an extra space and I left it there. That case is not a real trailing space but a space remained from breaking text into separate lines.

@sagikazarmark
Copy link
Member Author

Please see the link in my first comment

@weierophinney
Copy link
Contributor

@sagikazarmark Yes, I've looked at it. It looks good, and makes sense.

@sagikazarmark
Copy link
Member Author

Cool ;-)

philsturgeon added a commit that referenced this pull request Oct 14, 2014
[PSR-7] Removes trailing spaces from proposal
@philsturgeon philsturgeon merged commit fb03b35 into php-fig:master Oct 14, 2014
@sagikazarmark sagikazarmark deleted the hotfix/trailing-spaces branch October 14, 2014 17:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants