Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add explicit nullable type and bump minimal PHP version to 7.1 #17

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

alexandre-daubois
Copy link
Contributor

Goes in pair with the errata of the meta-document: php-fig/fig-standards#1321

Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This should be a more complete version of #16

@shadowhand shadowhand merged commit 2b4765f into php-fig:master Apr 15, 2024
@shadowhand
Copy link
Contributor

shadowhand commented Apr 15, 2024

Oh shoot, I wasn't supposed to merge this before vote. Can we leave it, and revert if the vote fails?

@Jean85
Copy link
Member

Jean85 commented Apr 15, 2024

Oh shoot, I wasn't supposed to merge this before vote. Can we leave it, and revert if the vote fails?

No problem, let's just not tag it in the meantime.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants