Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add Fatfree PSR7 package #78

Merged
merged 2 commits into from
Jan 4, 2025
Merged

add Fatfree PSR7 package #78

merged 2 commits into from
Jan 4, 2025

Conversation

ikkez
Copy link

@ikkez ikkez commented Jan 3, 2025

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets none
Documentation https://github.com/f3-factory/fatfree-psr7
License MIT

What's in this PR?

Add new package to the test suite.

@dbu
Copy link
Contributor

dbu commented Jan 3, 2025

thanks for the pull request. TIL about f3 framework.

something about the test boostrapping seems to be off, it does not find the URI implementation. can you please check the output of https://github.com/php-http/psr7-integration-tests/actions/runs/12597597127/job/35114756099?pr=78 ?

you can ignore the failures for all other clients, they are not affected by your changes.

@ikkez
Copy link
Author

ikkez commented Jan 3, 2025

thanks. weird it all just run fine locally here. Probably something with php unit testing constants. I've added fallback mechanisms to BaseTest.php just like it's done for other packages. 🤞 hope this helps.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, the fatfree tests are now all green 👍

@dbu dbu merged commit 76689df into php-http:1.x Jan 4, 2025
20 of 32 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants