Fixes for PECL bugs 60500 and 60501 #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 12, 2011 16:48
When performing a get with a cas token requested a multi-get is performed internally. After doing so only the first result is fetched, leaving the final RES_END result on the stack. As per the libmemcached documentation memcached_fetch_result should be called until it returns NULL following a multi-get. In some circumstances this is not noticeable as libmemcached takes care of flushing the receive buffers accordingly, however certain subsequent operations will incorrectly return the left-over RES_END result. I have seen this behaviour exhibited when performing a get with cas token request followed by an add operation though there may be other examples. I have tested this with memcached extension version 2.0.0b2 using libmemcached 0.53 and 1.0.2, though I believe the issue also exists with earlier versions. This commit addresses the issue by performing the necessary fetches and simplifies the call in the case that a cas token is not required by calling memcached_get_by_key.
|
Can somebody merge this? |
|
Just confirmed that this also fixes a bug when using |
|
Why such PRs don't get merged without a comment? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
60500: Fix get with CAS token not fetching all results
60501: Add binary protocol support to session handler
Further details are available in the commit messages/bug reports.