Fixes an incorrect libmemcached version check for OPT_PREFIX_KEY #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PREFIX_KEY functionality had a comment explaining that a bug
had to be worked around, in all version prior to 0.50. However,
that assumption was invalid, as the memcached_set_prefix_key()
behavior was only rewritten in version 0.49. Since the error was
fixed in libmemcached-0.50, that means it only exists in one version:
0.49.
I tested this fix against every release between 0.44 - 0.50, and
confirmed that the bug only has to be worked around in *exactly*
version 0.49.
The simple test:
$ nc -l localhost 5555
$ php -a
php > $mc = new Memcached();
php > $mc->addServer('localhost', 5555, 1);
php > $mc->setOption(Memcached::OPT_PREFIX_KEY, 'foo');
php > $mc->set('bar', 1, 15);
I saw "foo0bar" coming through in version 0.44 - 0.48. The problem
was fixed in 0.49 and 0.50.
iliaal
added a commit
that referenced
this pull request
Nov 10, 2012
|
Patch was applied. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PREFIX_KEY functionality had a comment explaining that a bug
had to be worked around, in all version prior to 0.50. However,
that assumption was invalid, as the memcached_set_prefix_key()
behavior was only rewritten in version 0.49. Since the error was
fixed in libmemcached-0.50, that means it only exists in one version:
0.49.
I tested this fix against every release between 0.44 - 0.50, and
confirmed that the bug only has to be worked around in exactly
version 0.49.
The simple test:
I saw "foo0bar" coming through in version 0.44 - 0.48. The problem
was fixed in 0.49 and 0.50.