Skip to content

Resolve: Setting dbType to enum is not totally correct #45 #46

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 9 commits into from
Dec 11, 2024

Conversation

SOHELAHMED7
Copy link
Member

Fixes #45

@SOHELAHMED7 SOHELAHMED7 requested a review from cebe September 6, 2024 03:51
@SOHELAHMED7 SOHELAHMED7 self-assigned this Sep 6, 2024
@SOHELAHMED7 SOHELAHMED7 linked an issue Sep 6, 2024 that may be closed by this pull request
@SOHELAHMED7 SOHELAHMED7 changed the title Draft: Setting dbType to enum is not totally correct #45 Resolve: Setting dbType to enum is not totally correct #45 Sep 6, 2024
@SOHELAHMED7 SOHELAHMED7 marked this pull request as ready for review September 6, 2024 11:36
@cebe
Copy link
Member

cebe commented Nov 12, 2024

Is it possible to write a test for the case fixed here?

…-correct' of github.com:php-openapi/yii2-openapi into 45-setting-dbtype-to-enum-is-not-totally-correct
@SOHELAHMED7
Copy link
Member Author

Yes it is possible but I think it is not needed. Because this PR only removes unnecessary code

        if (static::isEnum($newColumn)) {
            $newColumn->dbType = 'enum'; // TODO this is concretely not correct
        }

rest all changes are just of refactoring and not related to this PR.

Also existing test covers this PR:

so I think no new tests are needed

@SOHELAHMED7 SOHELAHMED7 merged commit ccd2f28 into master Dec 11, 2024
5 checks passed
@cebe cebe deleted the 45-setting-dbtype-to-enum-is-not-totally-correct branch December 11, 2024 13:57
@cebe
Copy link
Member

cebe commented Dec 11, 2024

Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting dbType to enum is not totally correct
2 participants