-
Notifications
You must be signed in to change notification settings - Fork 1
Avoid calling getSerializableData()
#98
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
… github.com:php-openapi/yii2-openapi into 81-avoid-calling-getserializabledata
changing the behavior of required and nullable is a major breaking change, if we want to do that we should do it before 2.0 stable release. Also need to check how that affects our spec in layer5. |
I will check this PR in L5 to see how much spec there requires change |
… github.com:php-openapi/yii2-openapi into 81-avoid-calling-getserializabledata
As I mentioned in #81 (comment),
While fixing 2nd, I found that 1st might be fixed without introducing breaking change if a change is introduced upstream library cebe/php-openapi. This change is required for 2nd. Change is to introduce a public property in namespace cebe\openapi;
abstract class SpecBaseObject implements SpecObjectInterface, DocumentContextInterface
{
+ public $rawSpec;
public function __construct(array $data)
{
+ $this->rawSpec = $data;
Though I still recommend to introduce breaking change and make this library more and more spec compliant. Example usage: 9538035 Implementation in upstream lib: cebe/php-openapi#228 |
This reverts commit 9538035.
… github.com:php-openapi/yii2-openapi into 81-avoid-calling-getserializabledata
Fixes #81
This PR requires cebe/php-openapi#228 to be merged first.
TODO