V2 #1
Merged
V2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e parameters from invoke()
Use API interface as return value and parameter for the API methods of the function interface. Make element interface JSON serializable and thus all children too.
The type would depend on the master type being either an input- or output- value. Tables are considered output values.
* Add JSON_* variables to be used for JSON encoded configurations. * Move methods handling the configuration to a separate interface. * Move configuration interfaces to a subdirectory. * Remove const TYPE from interfaces (the class names should do fine). * Remove incomplete configuration exception from configuration interfaces. This validation is expected to be job of the actual implementation. * Introduce jsonDecode() method as pendant to \JsonSerializeable interface.
* Make connection JSON serializeable. * Add methods to retrieve the configuration class. * Remove getId() method. * Remove connect() isConnected() and close() methods because this should be handled by the actual implementation internally. * Remove ping() methods, because this is essentially a function call.
IJsonSerializable doesn't work because jsonDecode() requires a connection configuration as mandatory parameter to correctly decode a function.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.