Skip to content

Commit

Permalink
Update php-sap/common to version 2.0
Browse files Browse the repository at this point in the history
* Removed any remains of typecasting.
  • Loading branch information
gregor-j committed Jan 22, 2019
1 parent 0f84060 commit a7c54a9
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 51 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"php": "~5.5.0",
"ext-saprfc": "*",
"php-sap/interfaces": "^1.0",
"php-sap/common": "^1.0"
"php-sap/common": "^2.0"
},
"require-dev": {
"ext-json": "*",
Expand Down
29 changes: 14 additions & 15 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 0 additions & 9 deletions src/AbstractRemoteFunctionCall.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,4 @@ protected function createConnectionInstance(IConfig $config)
{
return new SapRfcConnection($config);
}

/**
* Get the typecast of the expected return values.
* @return \kbATeam\TypeCast\ITypeCast|null
*/
protected function getReturnTypecast()
{
return null;
}
}
16 changes: 0 additions & 16 deletions tests/AbstractRemoteFunctionCallTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,20 +42,4 @@ public function testCreateConnectionInstance()
$connection = $rfc->createConnectionInstance($config);
static::assertInstanceOf(SapRfcConnection::class, $connection);
}

/**
* Test getting an empty return typecast.
*/
public function testGetReturnTypecast()
{
$config = new SapRfcConfigA([
'ashost' => 'sap.example.com',
'sysnr' => '001',
'client' => '002',
'user' => 'username',
'passwd' => 'password'
]);
$rfc = new RemoteFunctionCall($config);
static::assertNull($rfc->getReturnTypecast());
}
}
10 changes: 0 additions & 10 deletions tests/helper/RemoteFunctionCall.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,4 @@ public function createConnectionInstance(IConfig $config)
{
return parent::createConnectionInstance($config);
}

/**
* Make protected function public for testing.
* Get the typecast of the expected return values.
* @return \kbATeam\TypeCast\ITypeCast|null
*/
public function getReturnTypecast()
{
return parent::getReturnTypecast();
}
}

0 comments on commit a7c54a9

Please # to comment.