Skip to content

Allow multiple PHPStan tags with same name #183

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IanDelMar
Copy link
Contributor

Currently, there is no way to add two or more PHPStan tags with the same name, such as @phpstan-template. This issue was brought to my attention in #181, where both @phpstan-template and @template were used to keep both tags. This PR provides changes to the visitor to accommodate this need should it arise in the future.

Input format:

[
    'ClassName' => [null, '@phpstan-template' => ['T', 'TKey']],
]

which will produce

/**
 * @phpstan-template T
 * @phpstan-template TKey
 */
class ClassName {}

As there are currently no such cases in the functionMap, there is no need to merge this PR now. I just wanted to leave it here in case we need this change in the future.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant