Skip to content

Added CallableTypeBuilder #1

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

root-aza
Copy link
Contributor

@root-aza root-aza commented Dec 19, 2024

🔍 What was changed

Added new type builder:

  • TypeLang\Mapper\Type\Builder\PsrContainerTypeBuilder
  • TypeLang\Mapper\Type\Builder\CallableTypeBuilder

🤔 Why?

For friendly configuration for framework/psr-container

📝 Checklist

  • How was this tested:
    • Tested manually
    • Unit tests added

📃 Documentation

@root-aza root-aza marked this pull request as draft December 19, 2024 11:45
@SerafimArts
Copy link
Member

SerafimArts commented Dec 19, 2024

Сool idea 👍🏻

P.S. It might make sense to add a builder right away that gets a link to the container. And I think this will be a pretty popular solution for getting types directly from the container.

@SerafimArts SerafimArts self-assigned this Dec 19, 2024
@SerafimArts SerafimArts added enhancement New feature or request good first issue Good for newcomers labels Dec 19, 2024
@root-aza root-aza marked this pull request as ready for review December 20, 2024 04:11
@SerafimArts SerafimArts merged commit d36d545 into php-type-language:master Dec 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants