Ensure annotations work on tests that use dataProviders #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default $test->getName() appends the name of the data set (e.g. testInterceptsWithAnnotationsWhenUsingDataProvider with data set #0). This means that the reflection to get the doc block doesn't work.
renatomefi
requested changes
Oct 19, 2016
| @@ -122,7 +122,7 @@ public function addRiskyTest(PHPUnit_Framework_Test $test, Exception $e, $time) | |||
| public function startTest(PHPUnit_Framework_Test $test) | |||
| { | |||
| $class = get_class($test); | |||
| $method = $test->getName(); | |||
| $method = $test->getName(FALSE); | |||
There was a problem hiding this comment.
Can you put this false in lower case?
| public function aDataProvider() | ||
| { | ||
| return array( | ||
| array(null) |
There was a problem hiding this comment.
maybe you can put another item, this way we can make sure multiple iterations are happening. What do you think?
|
Great. I've made the boolean lowercase and added another entry to the dataProvider's array. All seems to be well. |
renatomefi
approved these changes
Oct 22, 2016
|
It looks good. Thanks @alnorth! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
$test->getName()appends the name of the data set (e.g. "testInterceptsWithAnnotationsWhenUsingDataProvider with data set #0"). This means that the reflection to get the doc block doesn't work.