Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PDO::getAttribute may throw PDOException #3029

Merged
merged 4 commits into from
Dec 24, 2023
Merged

Conversation

janedbal
Copy link
Contributor

This is currently undocumented behaviour, example here

@SakiTakamachi
Copy link
Member

SakiTakamachi commented Dec 19, 2023

This is also a known issue. I was a little wondering if I should just add it to the documentation, since even if I set the error mode to silent, I still get the warning.

php/php-src#12032

(edit)
However, there are other places where warnings occur even in silent mode, so it might be a good idea to add them to the documentation for now.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe needs to be slightly reordered to ideally be below the 80 characters by line guideline

reference/pdo/pdo/getattribute.xml Outdated Show resolved Hide resolved
reference/pdo/pdo/getattribute.xml Outdated Show resolved Hide resolved
janedbal and others added 2 commits December 22, 2023 19:19
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
@Girgias Girgias merged commit 5bef6e3 into php:master Dec 24, 2023
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants