Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Internal dev server 404 page is not responsive #17956

Closed
pascalchevrel opened this issue Mar 2, 2025 · 1 comment
Closed

Internal dev server 404 page is not responsive #17956

pascalchevrel opened this issue Mar 2, 2025 · 1 comment
Labels
Bug SAPI: cli_server Status: Verified

Comments

@pascalchevrel
Copy link
Contributor

Description

The 404 page for the internal development server (php -S localhost:8080) does not adapt to a mobile view which makes it hard to read.

Image

The html output just needs an added line to be responsive:
<meta name="viewport" content="width=device-width, initial-scale=1">

Which would give this result:

Image

I am happy to make a patch if necessary as it seems simple enough to just add this line and update the tests.

PHP Version

PHP 8.4.4

Operating System

Ubuntu 24.10
@devnexen
Copy link
Member

devnexen commented Mar 2, 2025

I would say go for the patch :)

pascalchevrel added a commit to pascalchevrel/php-src that referenced this issue Mar 2, 2025
@pascalchevrel
Fix phpGH-17956 Internal dev server 404 page is not responsive
c118e38 
Add a basic viewport html meta tag with responsive mode parameters
See: https://developer.mozilla.org/en-US/docs/Web/HTML/Viewport_meta_tag

Updated existing tests
@devnexen devnexen linked a pull request Mar 2, 2025 that will close this issue
Fix GH-17956 - Internal dev server 404 page is not responsive #17957
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Bug SAPI: cli_server Status: Verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GH-17956 - Internal dev server 404 page is not responsive pascalchevrel/php-src
3 participants
@pascalchevrel @devnexen @nielsdos