Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ext/standard: Sync parameter names for fpow() to be identical to pow() #16751

Closed
wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Nov 11, 2024

I don't know how this did not get caught before, but I found this out while writing the docs for fpow().
It should follow the same, more descriptive, parameter names of the pow() functions.

This needs RM approval, but I would hope this is uncontroversial @php/release-managers-84

Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new feature, there is no BC.
I support this because considering the named arguments thing, this is probably our last chance to fix it safely.

@Girgias
Copy link
Member Author

Girgias commented Nov 11, 2024

I will let CI run, and merge it if it is Green

Copy link
Member

@NattyNarwhal NattyNarwhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cosmetic, I agree shouldn't cause any problems

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants