Reduce excessive stack reserve for testing in CI #17166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the stack reserve of php.exe and php-cgi.exe is very large on Windows (64MB)[1]. While this might not be bad for production purposes, it causes stack_limit_014.phpt to be unbearably slow; the test may easily run for a minute, and due to a recent `stream_select()` improvement[2], that can cause a timeout, what triggers the test to be run again. So this single test case may run for two minutes, and still might fail (happened a couple of times). Instead of skipping the test in CI, we reduce the stack reserve to 8MB, what improves the performance of this test case (and maybe others), and should still be good enough for CI. [1] <php@54906c7> [2] <php@b614b4a>
|
Seems to work as expected: https://github.com/php/php-src/actions/runs/12339035646/job/34435498753?pr=17166#step:6:168 (only ~15 secs instead of ~120 secs or timing out). |
devnexen
reviewed
Dec 15, 2024
| @@ -131,6 +131,10 @@ for %%i in (ldap) do ( | |||
| del %PHP_BUILD_DIR%\php_%%i.dll | |||
| ) | |||
|
|
|||
| rem reduce excessive stack reserve for testing | |||
| editbin /stack:8388608 %PHP_BUILD_DIR%\php.exe | |||
There was a problem hiding this comment.
just curious is cl.exe able to do it at compile time ?
There was a problem hiding this comment.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the stack reserve of php.exe and php-cgi.exe is very large on Windows (64MB)[1]. While this might not be bad for production purposes, it causes stack_limit_014.phpt to be unbearably slow; the test may easily run for a minute, and due to a recent
stream_select()improvement[2], that can cause a timeout, what triggers the test to be run again. So this single test case may run for two minutes, and still might fail (happened a couple of times).Instead of skipping the test in CI, we reduce the stack reserve to 8MB, what improves the performance of this test case (and maybe others), and should still be good enough for CI.
[1] 54906c7
[2] b614b4a