Try building on windows-2025 #17760
Draft
Try building on windows-2025 #17760
+44
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest Windows release (24H2) apparently updated the JScript which can cause issues (see php#17759). Check if there are more.
This could should be revised; the whole caching was AppVeyor specific, and doesn't work as expected with GH runners. At least, this is unnecessarily complex.
To work around issues with DLLs we're using, but which are also in the system folder, we do `nmake snap` which (amongst other things) places our DLLs in the app folder, so these should be grabbed up first. This might take a bit long for CI, but let's see.
|
Someone put libcrypto-3-x64.dll in the system folder. Sigh. Fortunately, the PHP manual does not recommend such practice. ;) See https://learn.microsoft.com/en-us/windows/win32/dlls/dynamic-link-library-search-order, why that might be a bad idea. |
This reverts commit e1d0ef2. This doesn't work, unless we would target the subfolder with the snapshot build. It's also pretty slow.
That's even worse than putting non-system DLLs into the system folder.
Apparently, one of the more recent patch releases of Windows 10 (confirmed for Windows 10.0.26100, but may affect older versions, too) changed treatment of filenames with trailing slashes to be recognized explicitly as directories, and no longer as invalid file or directory. We adapt the affected test cases.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Windows release (24H2) apparently updated the JScript which can cause issues (see #17759). Check if there are more.