Add a custom Fast ZPP specifier for php_streams #17962
Merged
+147
−219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a corresponding test
Girgias
force-pushed
the
zpp-stream-specifier
branch
from
8f512ca to
4ed910a
Compare
Girgias
force-pushed
the
zpp-stream-specifier
branch
from
4ed910a to
cb07bd3
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on an old idea from @sgolemon.
This would reduce the complexity of the conversion from resources to opaque objects for streams when we finally get round to it.
The approach is similar to the one I did for the GMP extension functions that need to handle a complex union of types which doesn't warrant a dedicated Zend ZPP specifier.
Some obvious follow-ups: