sapi/fuzzer: Fetch function and call it directly instead of using a zval to hold the name #19030
+10
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…val to hold the name
nielsdos
requested changes
Jul 4, 2025
sapi/fuzzer/fuzzer-sapi.c
Outdated
| @@ -294,9 +294,11 @@ int fuzzer_do_request_from_buffer( | |||
| void fuzzer_call_php_func_zval(const char *func_name, int nargs, zval *args) { | |||
| zval retval, func; | |||
There was a problem hiding this comment.
You still have the func variable, which is still zval_ptr_dtor'ed at the end. That will now operate on uninitialized memory because it's never filled in / used.
nielsdos
approved these changes
Jul 5, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.