Fix zend_fibers.c build with ZEND_FIBER_UCONTEXT #7773
Conversation
Avoids (Solaris SPARC) issue: zend_fibers.c:77:9: error: unknown type name 'ucontext_t'
|
Thank you for the PR! This looks right, but should likely target PHP-8.1. |
I don't know the process. I was expecting it should go to 'master' first. Should I create new pull request against 'PHP-8.1' branch? |
No, that's not necessary. The "merger" can apply the patch to PHP-8.1, and merge into master from there. However, generally, a PR is supposed to target the lowest branch to which it is applicable; see also https://github.com/php/php-src/blob/master/CONTRIBUTING.md#pull-requests. |
| @@ -32,6 +32,10 @@ | |||
| # include <valgrind/valgrind.h> | |||
| #endif | |||
|
|
|||
| #ifdef ZEND_FIBER_UCONTEXT | |||
| # include <ucontext.h> | |||
There was a problem hiding this comment.
This could be moved below to line 76
There was a problem hiding this comment.
No, it's not possible. Line 76 is in struct { }.
|
Thanks again! |
|
@trowski please close https://bugs.php.net/bug.php?id=81689 as this PR fixed it |
|
@andypost Oh, interesting, I thought ppc64le would have used asm and not ucontext. Further, strange that you weren't seeing a similar error to the OP. Well, glad it's fixed. |
Avoids (Solaris SPARC) issue:
zend_fibers.c:77:9: error: unknown type name 'ucontext_t'