Skip to content

Commit

Permalink
[!!!TASK] Make all classes final
Browse files Browse the repository at this point in the history
This library has a very large number of extension points via
interfaces and abstract classes. All other classes should not
be extended by users and shall theirfor be marked as final.

There are a few classes left that should also be marked as final
but those require some extra attention.
  • Loading branch information
jaapio committed Jan 21, 2024
1 parent 185b77e commit fbd1a9d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/Graphs/DependencyInjection/Configuration.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

use function assert;

class Configuration implements ConfigurationInterface
final class Configuration implements ConfigurationInterface
{
public function getConfigTreeBuilder(): TreeBuilder
{
Expand Down
2 changes: 1 addition & 1 deletion src/Graphs/DependencyInjection/GraphsExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

use function dirname;

class GraphsExtension extends Extension implements PrependExtensionInterface
final class GraphsExtension extends Extension implements PrependExtensionInterface
{
/** @param mixed[] $configs */
public function load(array $configs, ContainerBuilder $container): void
Expand Down
2 changes: 1 addition & 1 deletion src/Graphs/Nodes/UmlNode.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

use phpDocumentor\Guides\Nodes\TextNode;

class UmlNode extends TextNode
final class UmlNode extends TextNode
{
private string $caption = '';

Expand Down
2 changes: 1 addition & 1 deletion src/Graphs/Renderer/PlantumlRenderer.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
use function sys_get_temp_dir;
use function tempnam;

class PlantumlRenderer implements DiagramRenderer
final class PlantumlRenderer implements DiagramRenderer
{
public function __construct(private readonly LoggerInterface $logger, private readonly string $plantUmlBinaryPath)
{
Expand Down

0 comments on commit fbd1a9d

Please # to comment.