-
-
Notifications
You must be signed in to change notification settings - Fork 15
[Bug]: Failed connection to plantuml server should not abort the rendering #965
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
And: a custom plantuml server is not the solution as it has to be maintained and updated regularly, which adds burdon to the projects who use guides. And also this server can be down which is annoying for users which then cannot render their documentation locally. |
I added a test case which shows warnings are triggered when the server is unreachable. If this is an issue on your side I would recommend to investigate the configuration of the httpclient. However I do not think it is changed on the typo3 side. @linawolf can you please investigate what is going on your side? |
@brotkrueml what error message do you get? |
I wrote that some weeks ago in the Slack channel; That the server is not reachable. It occured only seldomly - but then is very annoying as the whole rendering breaked. |
We do have a test-case in the guides, that shows if the server is not reachable there is a warning. So there must be some other issue here. Are there any error messages / exceptions when the rendering is breaking? |
There were already three commits merged after creating this issue. Maybe it is fixed now. |
So if it happens again please record what kind of error is displayed and open a new issue |
Summary
Currently, when the plantuml server is not available an error is thrown and the whole rendering is aborted. Therefore, I cannot check my changes locally, which are totally unrelated to this problem.
Code snippet that reproduces the problem
Add www.plantuml.com to your /etc/hosts with 127.0.0.1 or something similar.
Expected output
Instead a warning should be output, and the rendering should be finished.
For CI tasks which push those to a server, the warnings should abort the process, which would then be fine.
The text was updated successfully, but these errors were encountered: