Skip to content

[Bug]: Failed connection to plantuml server should not abort the rendering #965

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
brotkrueml opened this issue Mar 30, 2024 · 7 comments
Closed
Assignees
Labels
bug Something isn't working triage

Comments

@brotkrueml
Copy link
Contributor

Summary

Currently, when the plantuml server is not available an error is thrown and the whole rendering is aborted. Therefore, I cannot check my changes locally, which are totally unrelated to this problem.

Code snippet that reproduces the problem

Add www.plantuml.com to your /etc/hosts with 127.0.0.1 or something similar.

Expected output

Instead a warning should be output, and the rendering should be finished.

For CI tasks which push those to a server, the warnings should abort the process, which would then be fine.

@brotkrueml brotkrueml added bug Something isn't working triage labels Mar 30, 2024
@brotkrueml
Copy link
Contributor Author

And: a custom plantuml server is not the solution as it has to be maintained and updated regularly, which adds burdon to the projects who use guides. And also this server can be down which is annoying for users which then cannot render their documentation locally.

@jaapio
Copy link
Member

jaapio commented Apr 12, 2024

I added a test case which shows warnings are triggered when the server is unreachable. If this is an issue on your side I would recommend to investigate the configuration of the httpclient. However I do not think it is changed on the typo3 side.

@linawolf can you please investigate what is going on your side?

@linawolf
Copy link
Contributor

@brotkrueml what error message do you get?

@brotkrueml
Copy link
Contributor Author

I wrote that some weeks ago in the Slack channel; That the server is not reachable. It occured only seldomly - but then is very annoying as the whole rendering breaked.

@linawolf
Copy link
Contributor

We do have a test-case in the guides, that shows if the server is not reachable there is a warning. So there must be some other issue here. Are there any error messages / exceptions when the rendering is breaking?

@brotkrueml
Copy link
Contributor Author

brotkrueml commented Apr 21, 2024

There were already three commits merged after creating this issue. Maybe it is fixed now.

@linawolf
Copy link
Contributor

So if it happens again please record what kind of error is displayed and open a new issue

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

3 participants