Skip to content

[FEATURE] Create a rst theme to render markdown #1058

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

linawolf
Copy link
Contributor

No description provided.

@linawolf
Copy link
Contributor Author

linawolf commented Sep 6, 2024

@jaapio any chance you could help me here?

@linawolf linawolf marked this pull request as draft September 6, 2024 07:48
@jaapio
Copy link
Member

jaapio commented Sep 13, 2024

@linawolf I pushed a small addition to make your part working. You were missing something in the configuration of the new supported output format. I think when looking into this there is room for improvement. But it seems to work right now. I didn't look into the templates yet. But the changes I did are now used when rendering the output

@linawolf linawolf marked this pull request as ready for review September 30, 2024 10:09
@linawolf linawolf requested a review from jaapio September 30, 2024 10:09
@linawolf linawolf force-pushed the task/rst-theme branch 4 times, most recently from 9d31807 to caa4439 Compare September 30, 2024 13:45
@linawolf linawolf force-pushed the task/rst-theme branch 4 times, most recently from aecfa66 to 8b9b825 Compare October 12, 2024 01:23
@linawolf
Copy link
Contributor Author

@jaapio I can somehow not get psalm to work. Could you have a look please?

Convert basic mark-down into restructured Text

* headlines
* paragpraphs
* links
* lists
* emphasis
* inline-code
@jaapio jaapio enabled auto-merge October 18, 2024 12:49
@jaapio jaapio merged commit c000486 into main Oct 18, 2024
41 checks passed
@jaapio jaapio deleted the task/rst-theme branch October 18, 2024 12:51
@phpdoc-bot
Copy link

💔 All backports failed

Status Branch Result
1.x Backport failed because of merge conflicts

You might need to backport the following PRs to 1.x:
- Add deprecation trigger for context extension

Manual backport

To create the backport manually run:

backport --pr 1058

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@jaapio
Copy link
Member

jaapio commented Oct 18, 2024

💚 All backports created successfully

Status Branch Result
1.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jaapio added a commit that referenced this pull request Oct 18, 2024
[1.x] Merge pull request #1058 from phpDocumentor/task/rst-theme
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants