Skip to content

[BUGFIX] do not trim per line #1065

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 6, 2024
Merged

[BUGFIX] do not trim per line #1065

merged 1 commit into from
Sep 6, 2024

Conversation

jaapio
Copy link
Member

@jaapio jaapio commented Sep 4, 2024

Table cells may contain multiple lines as we did trim the cell content before the table parsing was completed we did mis empty lines. As empty lines where missing we did break the parsing process of a table cell.

fixes #955

Copy link
Contributor

@linawolf linawolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good solution

Table cells may contain multiple lines as we did trim the cell content before the table parsing was completed we did mis empty lines. As empty lines where missing we did break the parsing process of a table cell.
@jaapio jaapio force-pushed the fix/955-table-content branch from d0ac23a to 5e6d683 Compare September 6, 2024 17:00
@jaapio jaapio merged commit 5b95517 into main Sep 6, 2024
40 checks passed
@jaapio jaapio deleted the fix/955-table-content branch September 6, 2024 17:05
@phpdoc-bot
Copy link

💚 All backports created successfully

Status Branch Result
1.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

phpdoc-bot added a commit that referenced this pull request Sep 6, 2024
[1.x] Merge pull request #1065 from phpDocumentor/fix/955-table-content
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Gridtable does not support paragraphs and lists
3 participants