Skip to content

[1.x] Merge pull request #1193 from phpDocumentor/fix/table-colspan #1194

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ private function extractTableRows(ParserContext $context): array
}

/** @param array<int, int> $columnRanges */
private function extractRow(array $columnRanges, string $line, int &$currentSpan): TableRow
private function extractRow(array $columnRanges, string $line, int $currentSpan): TableRow
{
$row = new TableRow();
$currentColumnStart = null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,11 @@
<td>body row 2</td>
<td colspan="3">Cells may span columns.</td>
</tr>
<tr>
<td>body row 1, column 1</td>
<td>column 2</td>
<td>column 3</td>
<td>column 4</td>
</tr>
</tbody>
</table>
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@
+------------------------+------------+----------+----------+
| body row 2 | Cells may span columns. |
+------------------------+----------------------------------+
| body row 1, column 1 | column 2 | column 3 | column 4 |
+------------------------+------------+----------+----------+
Loading
Loading