Add CSS background colour for body #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As text is defined, but background was not. Most developers assume every browser has the same default colors, e.g. white for background. But actually users can alter those colors, and only changing one color will end up in a hard to read result. Therefore the background color is now explicitly set to the expected white defaults. Resolves phpDocumentor#3679
|
Thanks Daniel! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As text is defined, but background was not.
Most developers assume every browser has the same default colors, e.g. white for background.
But actually users can alter those colors, and only changing one color will end up in a hard to read result.
Therefore the background color is now explicitly set to the expected white defaults.
Resolves #3679