Cannot override being final for abstract classes

phpstan · Mar 6, 2025 · 9bb2ed5 · 9bb2ed5
1 parent 274e766
commit 9bb2ed5
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/Reflection/ClassReflection.php b/src/Reflection/ClassReflection.php
@@ -1283,7 +1283,7 @@ public function acceptsNamedArguments(): bool
 
 	public function hasFinalByKeywordOverride(): bool
 	{
-		return $this->isClass() && $this->finalByKeywordOverride !== null;
+		return $this->finalByKeywordOverride !== null;
 	}
 
 	public function isFinalByKeyword(): bool
@@ -1292,7 +1292,7 @@ public function isFinalByKeyword(): bool
 			return true;
 		}
 
-		if ($this->isClass() && $this->finalByKeywordOverride !== null) {
+		if ($this->finalByKeywordOverride !== null) {
 			return $this->finalByKeywordOverride;
 		}
 
@@ -1600,6 +1600,12 @@ public function asFinal(): self
 		if ($this->finalByKeywordOverride === true) {
 			return $this;
 		}
+		if (!$this->isClass()) {
+			return $this;
+		}
+		if ($this->isAbstract()) {
+			return $this;
+		}
 
 		return new self(
 			$this->reflectionProvider,