mktime does not return false in PHP 8.0+

[jaydiablo]

It seems that mktime (https://www.php.net/mktime) will not return false in PHP 8.0+ now. The PHP docs still show that as the signature, but the only way that seems possible to trigger it to return false (in PHP <8) doesn't work anymore because PHP 8 throws a TypeError if you try to pass a string argument (PHP 7 would throw a warning but still return false):

https://3v4l.org/R5JPS

gmmktime appears to function the same way:

https://3v4l.org/7JqeF

PHPStan currently sees mktime as possibly returning false, as seen here: https://phpstan.org/r/8c17702c-d5c9-444f-bcd7-624538d2fa62

[ondrejmirtes]

This fix will not help because the official stubs that have priority still have int|false: https://github.com/phpstan/php-8-stubs/blob/main/stubs/ext/date/mktime.php#L3

Please open an issue in https://github.com/php/php-src/. Either you'll find out when it returns false, or they'll fix the stub and docs, meaning it will eventually find its way into PHPStan.

Thanks.