fix(TSE-1157): Improve US datacenter documentation and typings #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Varpuspaavi
requested review from
francawinter,
itsahsiao,
lookasc,
flowreaction and
valeraine
as code owners
itsahsiao
reviewed
Aug 28, 2023
| @@ -76,12 +76,9 @@ initializePhraseAppEditor(config); | |||
|
|
|||
| #### Using the US Datacenter with ICE | |||
|
|
|||
| In addition to `phraseEnabled`, `projectId` and `accountID` in the config, also add the US specific URLs to enable working through the US endpoint. | |||
There was a problem hiding this comment.
Question - why is accountID removed from the description here? The config above on Lines 66-70 has it there 🤔
If we don't want to list these properties, we could adjust this line to In addition to the settings in your config, set the US datacenter to enable it working with the US endpoints.
itsahsiao
approved these changes
Aug 28, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 28, 2023
## [1.1.3](v1.1.2...v1.1.3) (2023-08-28) ### Bug Fixes * **TSE-1157:** Improve US datacenter documentation and typings ([#47](#47)) ([961b0ef](961b0ef))
|
🎉 This PR is included in version 1.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phrase.atlassian.net/browse/TSE-1157