Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

allow overwriting file extensions this plugin runs for #7

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

vkarpov15
Copy link
Contributor

Nice plugin! I got it mostly working for temporalio/documentation#496, the only issue is that we use .md instead of .mdx for our MDX files and there's no workaround for running this plugin on .md files.

@phryneas
Copy link
Owner

Hmm. The plugin generates mdx output - would this even work in a .md file? 🤔

I mean, if it does work for you I'm happy to merge, just wondering 😅

@vkarpov15
Copy link
Contributor Author

Any md file is valid mdx, modulo edge cases :) I think the rationale is that our docs are written in plain markdown, hence .md, but docusaurus compiles the markdown files as mdx, so plugins can insert mdx functionality.

@slorber
Copy link

slorber commented Jul 15, 2021

By default Docusaurus compile both .md/.mdx with MDX so that seems like a good option to allow this

Note in practice it's annoying for a few users because adopting Docusaurus means that commonmark docs are not always 100% compatible (facebook/docusaurus#3018)

@phryneas
Copy link
Owner

Then let's get this in :)

@phryneas phryneas merged commit 9c173db into phryneas:main Jul 16, 2021
@phryneas
Copy link
Owner

This has been released in v1.0.9

@vkarpov15
Copy link
Contributor Author

Thanks 👍 I'll take a look at integrating this into temporal's docs next week.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants