Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add "piccolo user list" command #921

Merged
merged 1 commit into from
Jan 22, 2024
Merged

add "piccolo user list" command #921

merged 1 commit into from
Jan 22, 2024

Conversation

waldner
Copy link
Contributor

@waldner waldner commented Jan 22, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (17e9448) 91.99% compared to head (6c575f7) 91.80%.

Files Patch % Lines
piccolo/utils/printing.py 11.11% 16 Missing ⚠️
piccolo/apps/user/commands/list.py 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
- Coverage   91.99%   91.80%   -0.19%     
==========================================
  Files         107      108       +1     
  Lines        8165     8187      +22     
==========================================
+ Hits         7511     7516       +5     
- Misses        654      671      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dantownsend dantownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thanks!

I left a few comments.

@dantownsend
Copy link
Member

OK, this looks good - thanks! I'll merge it in.

I'll add a really basic test for code coverage.

@dantownsend dantownsend merged commit b888cef into piccolo-orm:master Jan 22, 2024
46 checks passed
@waldner
Copy link
Contributor Author

waldner commented Jan 22, 2024

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants