Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

💥 Fix iPad crash due to missing sourceView #1933

Conversation

michalsrutek
Copy link
Contributor

Connection with issue(s)

Resolve issue #1928

Connected to #1928

Testing and Review Notes

The sourceView was missing. It might also be missing in other places, but I haven't yet got time to check - can be done in future PRs.

Also, the look is not ideal, as it's really narrow - but that's for another PR. The main thing is that this scenario does not cause crashes anymore 🎉 .

Screenshots or Videos

Simulator Screenshot - iPad Pro (12 9-inch) (6th generation) - 2023-12-20 at 12 11 29

@michalsrutek michalsrutek changed the title Fix iPad crash due to missing sourceView 💥 Fix iPad crash due to missing sourceView Dec 21, 2023
@michalsrutek michalsrutek changed the title 💥 Fix iPad crash due to missing sourceView 💥 Fix iPad crash due to missing sourceView Dec 23, 2023
@michalsrutek
Copy link
Contributor Author

@pichillilorenzo can we get this merged and released? 🙏

@pichillilorenzo
Copy link
Owner

Thanks for all the pull requests!
I will check them as soon as possible to get them merged 👍

@pichillilorenzo pichillilorenzo merged commit 5b42251 into pichillilorenzo:master Dec 23, 2023
@pichillilorenzo
Copy link
Owner

By the way, you can change the presentation style using InAppBrowserSettings.presentationStyle property, for example:

settings: InAppBrowserClassSettings(
  browserSettings: InAppBrowserSettings(
      toolbarTopBackgroundColor: Colors.blue,
      presentationStyle: ModalPresentationStyle.PAGE_SHEET),
  webViewSettings: InAppWebViewSettings(
    isInspectable: kDebugMode,
    useShouldOverrideUrlLoading: true,
    useOnLoadResource: true,
  ),
),

@pichillilorenzo
Copy link
Owner

@all-contributors please add @michalsrutek for code

Copy link
Contributor

@pichillilorenzo

I've put up a pull request to add @michalsrutek! 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants