Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bugfix/ajax-blob #2099

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EArminjon
Copy link
Contributor

@EArminjon EArminjon commented Apr 9, 2024

Smell like code issue. blob variable used previously was not defined. On blob, request.response contain a blob object, let's use it.

Connection with issue(s)

Resolve issue #2098

Connected to #2098

Testing and Review Notes

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@EArminjon
Copy link
Contributor Author

EArminjon commented Apr 16, 2024

@pichillilorenzo

I wonder about the following code callback(null) :

Capture d’écran 2024-04-16 à 14 38 23

I believe we should also give request.response because what will happen if reques.response exist and request.responseType is null ? We lost the result...

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant