Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix HTTPCookie.secure #311

Merged
merged 1 commit into from
May 9, 2020
Merged

Conversation

xtyxtyx
Copy link
Contributor

@xtyxtyx xtyxtyx commented Mar 26, 2020

Connection with issue(s)

Resolve issue #118

Testing and Review Notes

According to https://developer.apple.com/documentation/foundation/httpcookiepropertykey/1392985-secure, .secure key of HTTPCookie shouldn't be set when the cookie isn't secure. Otherwise, cookies are always 'secure' and won't work on http urls.

@arnaudelub
Copy link

If you want, as the maintainer is out for quite a long time now, we are maintaining this fork:
https://github.com/arnaudelub/flutter_polywebview
package also available on pub.dev:
https://pub.dev/packages/flutter_polywebview

feel free to add you PR on this fork if you want.

@pichillilorenzo pichillilorenzo merged commit 4d0cde4 into pichillilorenzo:develop May 9, 2020
@pichillilorenzo
Copy link
Owner

Released new version 3.0.0. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants