Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Wrong config keys in discoverPageSiblings #675

Closed
zeleznypa opened this issue Sep 1, 2023 · 1 comment
Closed

Wrong config keys in discoverPageSiblings #675

zeleznypa opened this issue Sep 1, 2023 · 1 comment

Comments

@zeleznypa
Copy link

Rest of the code use pages_order and pages_order_by keys.

Pico/lib/Pico.php

Line 1889 in 09aa825

if (($this->getConfig('order_by') === 'date') && ($this->getConfig('order') === 'desc')) {

@PhrozenByte
Copy link
Collaborator

Good catch! 👍 A pull request on the pico-3.0 branch (even though it's clearly a bug, it still is a breaking change: people likely circumvented it by other means already) is very welcome.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants